[GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
Hello Friends,

As you may or may not know, I have been working on a responsive skin for
XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As I
continue to add further details and refinements into the skin, I would like
to kindly ask for your help in doing so. In order to make sure that I did
not miss anything and the skin is as complete as possible, I would like to,
if possible, request a XAR of an existing wiki (or complex pages) so that I
may see the result of implementing the skin on more than the default wiki
data.

If this is not a possible, I would like to still enlist your help in
testing some basic/your favorite functionality/features of xwiki. There are
several ways to do this:

   - By downloading the current skin and testing it on your XWiki:
   https://github.com/jssolichin/xo5
   - By playing around with the live instance (uses default admin
   user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
   - By letting me know of your favorite applications (so that I may look
   into implementing them)

Anything you want to note is fine. Bug and feature request are both
welcome, as I think communal ideas are often better than one. Even if you
did not have a chance to play too much with the skin, go ahead and let me
know what you think I should check on (based on your experience) and/or
give me any suggestions that may have come up while reading this.
Technicality permitting, I will check myself.

Helping with this process will help make the skin better, and maybe help it
to be tailored to your (/type of) wiki and the community surrounding the
platform in general.

Thank you in advance for your time!
Jonathan Solichin
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jerome Velociter-4
Hi Jonathan,

Allow me first to leave some remarks as I've wrote them down when checking
out your work :

* The main content area scrolls when clicking the sidebar control icons.
This seem to happen only when the page is already a bit scrolled. Is this
the expected behavior ?
* Clicking the search box redirects to the home page
* Seems the history UI is not loading with AJAX as colibri does it. I think
it would be a questionnable approach, as it increases the cost of loading a
page, while the history will not be checked out by users most of the times.
* Internationalization is missing. (For example the "Swipe horizontally to
access menu")
* Do you have any use of modernizr ? If not we should remove it.
* There is no edit mode switcher when editing the page. If you update your
repos you can checkout how I've done it for Lyrebird
* The "profile" and "logout" links overlap the sidebar controls on Firefox.
See http://i.imgur.com/LRgIc.png
* Top "Add" menu "add comment to page" and "add attachment to page" have no
effect
* The "document index" tabs don't look too good when small screen estate.
See http://imgur.com/GalCk

That should be about it for now.

Regarding the next items that could be addressed, here is what I have in
mind :
* Search. The synchronous search UI seems fine, but now it would be great
to have a functional search suggest.
* Ensure consistency of styles across the standard XE UI. I've seen some
forms remain un-styled, for example the "Add space" and "Add page" ones. This
is a work of playing hide and seek with your wiki :)
* It would be good that you document your patch on the livetable macros/JS
somewhere so that it's easier for us to understand what you've done and
possibly to integrate it
* Color themes ? Apps ?

Thanks, and keep up the good work !

Jerome

On Tue, Jul 17, 2012 at 8:50 PM, Jonathan Solichin <[hidden email]>wrote:

> Hello Friends,
>
> As you may or may not know, I have been working on a responsive skin for
> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As
> I
> continue to add further details and refinements into the skin, I would like
> to kindly ask for your help in doing so. In order to make sure that I did
> not miss anything and the skin is as complete as possible, I would like to,
> if possible, request a XAR of an existing wiki (or complex pages) so that I
> may see the result of implementing the skin on more than the default wiki
> data.
>
> If this is not a possible, I would like to still enlist your help in
> testing some basic/your favorite functionality/features of xwiki. There are
> several ways to do this:
>
>    - By downloading the current skin and testing it on your XWiki:
>    https://github.com/jssolichin/xo5
>    - By playing around with the live instance (uses default admin
>    user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>    - By letting me know of your favorite applications (so that I may look
>    into implementing them)
>
> Anything you want to note is fine. Bug and feature request are both
> welcome, as I think communal ideas are often better than one. Even if you
> did not have a chance to play too much with the skin, go ahead and let me
> know what you think I should check on (based on your experience) and/or
> give me any suggestions that may have come up while reading this.
> Technicality permitting, I will check myself.
>
> Helping with this process will help make the skin better, and maybe help it
> to be tailored to your (/type of) wiki and the community surrounding the
> platform in general.
>
> Thank you in advance for your time!
> Jonathan Solichin
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs
>



--
Jérôme Velociter
Winesquare
http://www.winesquare.net/
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jerome Velociter-4
On Sat, Jul 21, 2012 at 3:05 PM, Jerome Velociter <[hidden email]>wrote:

> Hi Jonathan,
>
> Allow me first to leave some remarks as I've wrote them down when checking
> out your work :
>
> * The main content area scrolls when clicking the sidebar control icons.
> This seem to happen only when the page is already a bit scrolled. Is this
> the expected behavior ?
> * Clicking the search box redirects to the home page
> * Seems the history UI is not loading with AJAX as colibri does it. I
> think it would be a questionnable approach, as it increases the cost of
> loading a page, while the history will not be checked out by users most of
> the times.
> * Internationalization is missing. (For example the "Swipe horizontally to
> access menu")
> * Do you have any use of modernizr ? If not we should remove it.
> * There is no edit mode switcher when editing the page. If you update your
> repos you can checkout how I've done it for Lyrebird
> * The "profile" and "logout" links overlap the sidebar controls on
> Firefox. See http://i.imgur.com/LRgIc.png
> * Top "Add" menu "add comment to page" and "add attachment to page" have
> no effect
> * The "document index" tabs don't look too good when small screen estate.
> See http://imgur.com/GalCk
>

There's an issue when viewing a page that do not exist : see
http://i.imgur.com/4Y6x5.png

Jerome


> That should be about it for now.
>
> Regarding the next items that could be addressed, here is what I have in
> mind :
> * Search. The synchronous search UI seems fine, but now it would be great
> to have a functional search suggest.
> * Ensure consistency of styles across the standard XE UI. I've seen some
> forms remain un-styled, for example the "Add space" and "Add page" ones. This
> is a work of playing hide and seek with your wiki :)
> * It would be good that you document your patch on the livetable macros/JS
> somewhere so that it's easier for us to understand what you've done and
> possibly to integrate it
> * Color themes ? Apps ?
>
> Thanks, and keep up the good work !
>
> Jerome
>
> On Tue, Jul 17, 2012 at 8:50 PM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hello Friends,
>>
>> As you may or may not know, I have been working on a responsive skin for
>> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome).
>> As I
>> continue to add further details and refinements into the skin, I would
>> like
>> to kindly ask for your help in doing so. In order to make sure that I did
>> not miss anything and the skin is as complete as possible, I would like
>> to,
>> if possible, request a XAR of an existing wiki (or complex pages) so that
>> I
>> may see the result of implementing the skin on more than the default wiki
>> data.
>>
>> If this is not a possible, I would like to still enlist your help in
>> testing some basic/your favorite functionality/features of xwiki. There
>> are
>> several ways to do this:
>>
>>    - By downloading the current skin and testing it on your XWiki:
>>    https://github.com/jssolichin/xo5
>>    - By playing around with the live instance (uses default admin
>>    user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>    - By letting me know of your favorite applications (so that I may look
>>    into implementing them)
>>
>> Anything you want to note is fine. Bug and feature request are both
>> welcome, as I think communal ideas are often better than one. Even if you
>> did not have a chance to play too much with the skin, go ahead and let me
>> know what you think I should check on (based on your experience) and/or
>> give me any suggestions that may have come up while reading this.
>> Technicality permitting, I will check myself.
>>
>> Helping with this process will help make the skin better, and maybe help
>> it
>> to be tailored to your (/type of) wiki and the community surrounding the
>> platform in general.
>>
>> Thank you in advance for your time!
>> Jonathan Solichin
>> _______________________________________________
>> devs mailing list
>> [hidden email]
>> http://lists.xwiki.org/mailman/listinfo/devs
>>
>
>
>
> --
> Jérôme Velociter
> Winesquare
> http://www.winesquare.net/
>



--
Jérôme Velociter
Winesquare
http://www.winesquare.net/
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
Hi Jerome,

First thank you for the detailed analysis. They are very helpful.

* The main content area scrolls when clicking the sidebar control icons.
> This seem to happen only when the page is already a bit scrolled. Is this
> the expected behavior ?
>
This is expected and is a result of using the browser's native scrolling
mechanism (anchor link). This was done in order to rely less on js for
primary navigation/control. I thought it was minor enough, but if you think
it should be changed, i think this issue could be removed via js.


> * Clicking the search box redirects to the home page
>
Oops, it's fixed now.

* Seems the history UI is not loading with AJAX as colibri does it. I think
> it would be a questionnable approach, as it increases the cost of loading
> a
> page, while the history will not be checked out by users most of the
> times.
>
Good idea. I just updated it so it would load on ajax (also, relevant to
the below point, made it more international friendly)


> * Internationalization is missing. (For example the "Swipe horizontally to
> access menu")
>
Yes, I've been thinking about this. I was wondering how I should go about
this. Internationalization would take a lot of (community) work it seems.
And I was wondering whether the "swipe horizontally" is needed at all. I
know that in most apps they do not mention this, but the argument would be
that app are long term usage scenarios. What are your thoughts?


> * Do you have any use of modernizr ? If not we should remove it.
>
Modernizr is used both to better degrade opacity, rotation and other
niceties, and to decide the web layout. As I mentioned in the
proposal/design some of the issues are the wildly varying pixel densities.
Eg. the Nexus7 (my personal test platform), has a 1024x800 but is only 7
inch, so it doesn't work as well with the sidebar layout as it would with
the mobile layout. So what it's doing right now is to check the screen size
and whether it is touch screen (most laptop has about equivalent density
(except for maybe the new macbook), but, even then, those are still not
very relevant because they are usually top of the line and exceed the pixel
size of tablets). Media queries presently do not yet have touch identifier,
so modernizr is used in conjunction. Is this ok, or should i try to find a
better solution?

* There is no edit mode switcher when editing the page. If you update your
> repos you can checkout how I've done it for Lyrebird
>
Ok, thanks


> * The "profile" and "logout" links overlap the sidebar controls on
> Firefox.
> See http://i.imgur.com/LRgIc.png
>
Hmm, that's strange, it didn't do that on my end. Thanks for bringing it
up.

 <http://i.imgur.com/LRgIc.png>* Top "Add" menu "add comment to page" and
> "add attachment to page" have no
> effect
>
 What do you mean by this? Sorry

* The "document index" tabs don't look too good when small screen estate.
> See http://imgur.com/GalCk

Ok, thanks


> That should be about it for now.
> Regarding the next items that could be addressed, here is what I have in
> mind :
> * Search. The synchronous search UI seems fine, but now it would be great
> to have a functional search suggest.
>
Ok, I will look into this.

* Ensure consistency of styles across the standard XE UI. I've seen some
> forms remain un-styled, for example the "Add space" and "Add page" ones.
> This
> is a work of playing hide and seek with your wiki :)
>
Yes, i've been trying to hunt them down as much as I can, and will continue
to do so.


> * It would be good that you document your patch on the livetable macros/JS
> somewhere so that it's easier for us to understand what you've done and
> possibly to integrate it
>
 Ok, how would you suggest I do this/where? Briefly, I used this technique (
http://filamentgroup.com/lab/responsive_design_approach_for_complex_multicolumn_data_tables/
).

* Color themes ? Apps ?

For apps, I wanted to confirm: skinning is only possible via css, and not
its html (since it's html is not from the templates folder)?

There's an issue when viewing a page that do not exist : see
> http://i.imgur.com/4Y6x5.png

Ah, good catch, thanks

Thank you again for helping/mentoring with this project (sidenote: have fun
with, what I gathered, the XWiki annual seminar)

Best,
Jonathan Solichin
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
Hi Jerome,

All the advise you mentioned should now be fixed on github. Ajax search is
now implemented.

I will be working on color themes, while still trying to ensure consistency
through out XE UI.

Thank you again!
Jonathan Solichin

On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <[hidden email]>wrote:

> Hello Friends,
>
> As you may or may not know, I have been working on a responsive skin for
> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As
> I continue to add further details and refinements into the skin, I would
> like to kindly ask for your help in doing so. In order to make sure that I
> did not miss anything and the skin is as complete as possible, I would like
> to, if possible, request a XAR of an existing wiki (or complex pages) so
> that I may see the result of implementing the skin on more than the default
> wiki data.
>
> If this is not a possible, I would like to still enlist your help in
> testing some basic/your favorite functionality/features of xwiki. There are
> several ways to do this:
>
>    - By downloading the current skin and testing it on your XWiki:
>    https://github.com/jssolichin/xo5
>    - By playing around with the live instance (uses default admin
>    user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>    - By letting me know of your favorite applications (so that I may look
>    into implementing them)
>
> Anything you want to note is fine. Bug and feature request are both
> welcome, as I think communal ideas are often better than one. Even if you
> did not have a chance to play too much with the skin, go ahead and let me
> know what you think I should check on (based on your experience) and/or
> give me any suggestions that may have come up while reading this.
> Technicality permitting, I will check myself.
>
> Helping with this process will help make the skin better, and maybe help
> it to be tailored to your (/type of) wiki and the community surrounding the
> platform in general.
>
> Thank you in advance for your time!
> Jonathan Solichin
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
On 07/26/2012 10:42 AM, Jonathan Solichin wrote:
> Hi Jerome,
>
> All the advise you mentioned should now be fixed on github. Ajax search is
> now implemented.

For the record, we are discussing this here :
https://github.com/jssolichin/xo5/commit/d85d1f90d023197f825cf22f7d95616a011962be#L0L-1

Another topic : I think it would be great if you could split xwiki.css
in two files : one with styles specific to xorange (xo-content styling,
etc.) and another one with XWiki-specific styles - even when related to
the layout and responsivness of xorange.
The goal is to make it easy to derive your skin to build other
responsive skins. I for instance plan to redesign my personal site based
on your work.

Peace,
Jerome

>
> I will be working on color themes, while still trying to ensure consistency
> through out XE UI.
>
> Thank you again!
> Jonathan Solichin
>
> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hello Friends,
>>
>> As you may or may not know, I have been working on a responsive skin for
>> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As
>> I continue to add further details and refinements into the skin, I would
>> like to kindly ask for your help in doing so. In order to make sure that I
>> did not miss anything and the skin is as complete as possible, I would like
>> to, if possible, request a XAR of an existing wiki (or complex pages) so
>> that I may see the result of implementing the skin on more than the default
>> wiki data.
>>
>> If this is not a possible, I would like to still enlist your help in
>> testing some basic/your favorite functionality/features of xwiki. There are
>> several ways to do this:
>>
>>     - By downloading the current skin and testing it on your XWiki:
>>     https://github.com/jssolichin/xo5
>>     - By playing around with the live instance (uses default admin
>>     user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>     - By letting me know of your favorite applications (so that I may look
>>     into implementing them)
>>
>> Anything you want to note is fine. Bug and feature request are both
>> welcome, as I think communal ideas are often better than one. Even if you
>> did not have a chance to play too much with the skin, go ahead and let me
>> know what you think I should check on (based on your experience) and/or
>> give me any suggestions that may have come up while reading this.
>> Technicality permitting, I will check myself.
>>
>> Helping with this process will help make the skin better, and maybe help
>> it to be tailored to your (/type of) wiki and the community surrounding the
>> platform in general.
>>
>> Thank you in advance for your time!
>> Jonathan Solichin
>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
---Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
I think that's a great idea, it would make the skin more extensible. Right
now I am exploring creating a xar to create a page where there can be
options-- right now for the colors, like you did with the "fluid" option on
lyrebird.

As I am separating the codes, i am wondering how far i should separate the
core?  Should i just leave enough css that there is a sidebar, the header,
and the main content area?

Thank you,
Jonathan Solichin

On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin
<[hidden email]>wrote:

> I think that's a great idea, it would make the skin more extensible. Right
> now I am exploring creating a xar to create a page where there can be
> options-- right now for the colors, like you did with the "fluid" option on
> lyrebird.
>
> As I am separating the codes, i am wondering how far i should separate the
> core?  Should i just leave enough css that there is a sidebar, the header,
> and the main content area?
>
> Thank you,
> Jonathan Solichin
>
>
> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hi Jerome,
>>
>> All the advise you mentioned should now be fixed on github. Ajax search
>> is now implemented.
>>
>> I will be working on color themes, while still trying to ensure
>> consistency through out XE UI.
>>
>> Thank you again!
>> Jonathan Solichin
>>
>>
>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <[hidden email]
>> > wrote:
>>
>>> Hello Friends,
>>>
>>> As you may or may not know, I have been working on a responsive skin for
>>> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome).
>>> As I continue to add further details and refinements into the skin, I would
>>> like to kindly ask for your help in doing so. In order to make sure that I
>>> did not miss anything and the skin is as complete as possible, I would like
>>> to, if possible, request a XAR of an existing wiki (or complex pages) so
>>> that I may see the result of implementing the skin on more than the default
>>> wiki data.
>>>
>>> If this is not a possible, I would like to still enlist your help in
>>> testing some basic/your favorite functionality/features of xwiki. There are
>>> several ways to do this:
>>>
>>>    - By downloading the current skin and testing it on your XWiki:
>>>    https://github.com/jssolichin/xo5
>>>    - By playing around with the live instance (uses default admin
>>>    user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>>    - By letting me know of your favorite applications (so that I may
>>>    look into implementing them)
>>>
>>> Anything you want to note is fine. Bug and feature request are both
>>> welcome, as I think communal ideas are often better than one. Even if you
>>> did not have a chance to play too much with the skin, go ahead and let me
>>> know what you think I should check on (based on your experience) and/or
>>> give me any suggestions that may have come up while reading this.
>>> Technicality permitting, I will check myself.
>>>
>>> Helping with this process will help make the skin better, and maybe help
>>> it to be tailored to your (/type of) wiki and the community surrounding the
>>> platform in general.
>>>
>>> Thank you in advance for your time!
>>> Jonathan Solichin
>>>
>>
>>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
On 07/30/2012 10:09 PM, Jonathan Solichin wrote:
> I think that's a great idea, it would make the skin more extensible. Right
> now I am exploring creating a xar to create a page where there can be
> options-- right now for the colors, like you did with the "fluid" option on
> lyrebird.
>
> As I am separating the codes, i am wondering how far i should separate the
> core?  Should i just leave enough css that there is a sidebar, the header,
> and the main content area?

Yes it sounds good.

I agree it's difficult to arbitrate between what is "core" and what is
style. I would tend to think that the core skin needs to have proper
positionning, proper margins etc. and a good set of neutral defaults for
colors, fonts and the rest. Then the actual xorange CSS overrides those
defaults.

This is an area I can help you test, I actually have already started
implementing my own skin that derives xorange.

>
> Thank you,
> Jonathan Solichin
>
> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin
> <[hidden email]>wrote:
>
>> I think that's a great idea, it would make the skin more extensible. Right
>> now I am exploring creating a xar to create a page where there can be
>> options-- right now for the colors, like you did with the "fluid" option on
>> lyrebird.
>>
>> As I am separating the codes, i am wondering how far i should separate the
>> core?  Should i just leave enough css that there is a sidebar, the header,
>> and the main content area?
>>
>> Thank you,
>> Jonathan Solichin
>>
>>
>> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]>wrote:
>>
>>> Hi Jerome,
>>>
>>> All the advise you mentioned should now be fixed on github. Ajax search
>>> is now implemented.
>>>
>>> I will be working on color themes, while still trying to ensure
>>> consistency through out XE UI.
>>>
>>> Thank you again!
>>> Jonathan Solichin
>>>
>>>
>>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <[hidden email]
>>>> wrote:
>>>> Hello Friends,
>>>>
>>>> As you may or may not know, I have been working on a responsive skin for
>>>> XWiki for GSOC (http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome).
>>>> As I continue to add further details and refinements into the skin, I would
>>>> like to kindly ask for your help in doing so. In order to make sure that I
>>>> did not miss anything and the skin is as complete as possible, I would like
>>>> to, if possible, request a XAR of an existing wiki (or complex pages) so
>>>> that I may see the result of implementing the skin on more than the default
>>>> wiki data.
>>>>
>>>> If this is not a possible, I would like to still enlist your help in
>>>> testing some basic/your favorite functionality/features of xwiki. There are
>>>> several ways to do this:
>>>>
>>>>     - By downloading the current skin and testing it on your XWiki:
>>>>     https://github.com/jssolichin/xo5
>>>>     - By playing around with the live instance (uses default admin
>>>>     user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>>>     - By letting me know of your favorite applications (so that I may
>>>>     look into implementing them)
>>>>
>>>> Anything you want to note is fine. Bug and feature request are both
>>>> welcome, as I think communal ideas are often better than one. Even if you
>>>> did not have a chance to play too much with the skin, go ahead and let me
>>>> know what you think I should check on (based on your experience) and/or
>>>> give me any suggestions that may have come up while reading this.
>>>> Technicality permitting, I will check myself.
>>>>
>>>> Helping with this process will help make the skin better, and maybe help
>>>> it to be tailored to your (/type of) wiki and the community surrounding the
>>>> platform in general.
>>>>
>>>> Thank you in advance for your time!
>>>> Jonathan Solichin
>>>>
>>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
—Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Ecaterina Moraru (Valica)
Hi Jonathan,

Regarding the Skin testing - one solution would be to test it on incubator (
http://incubator.myxwiki.org/) as long as you don't broke everything there
(especially the Improvements space) :) but I guess a skin should be
harmless, right? ;)

Now some problems:

After I logged in I really don't know what button to press in order to edit
the Main.WebHome.

Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that
you choose to align them right. Our standard is vertical-aligned-left
http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms
I notice this on login page and on editing pages. This is easily fixable
from CSS (.buttons class).

You stripped all the CSS, so there will be lots of problems in lots of
places. Maybe you should put back all the style dependencies.
- You don't have any style for error boxes (
http://23.21.87.183:8080/xwiki/bin/view/XWiki/OfficeImporter?&parent=XWiki.Admin).
The style for info is not noticeable enough(looks very similar to table
headers). The style used for warning is better suited for error macro.
- The page -> Share by email feature is style-less.
- .xform style for .xHint are gone (you can observe this when creating
pages/spaces)
- Administration -> ColorThemes can't be edited anymore in inline mode (the
JS doesn't work)
- Administration -> Panel Wizard is broken too
- Administration -> Users, Groups (adding, editing, deleting users/groups)
doesn't work
- Lots of sections in Administration are missing the styles + some portion
of settings are displayed after the administration menu ends (Chrome) (you
need to scroll in order to see all the options, see Administration ->
Applications -> WYSIWYG Editor settings )
- Problems with Blog posts in view and edit modes
- Pages with few content look kind of strange :)
http://23.21.87.183:8080/xwiki/bin/view/Sandbox/TestPage2 or
http://23.21.87.183:8080/xwiki/bin/view/Main/CC
- Some more left-right margins on content would be nice (looks crowded).
25px+ would work better than 10px margins on #xo-content
- I like the Administration breadcrumb :p
- I like how some forms look in edit mode :) like editing the Profile,
although there are some issues with the sections H1

Restyling the whole wiki is a big task and there are lots of things to do,
but until now looks great.

Thanks for your work,
Caty

On Tue, Jul 31, 2012 at 11:52 AM, Jerome Velociter <[hidden email]>wrote:

> On 07/30/2012 10:09 PM, Jonathan Solichin wrote:
>
>> I think that's a great idea, it would make the skin more extensible. Right
>> now I am exploring creating a xar to create a page where there can be
>> options-- right now for the colors, like you did with the "fluid" option
>> on
>> lyrebird.
>>
>> As I am separating the codes, i am wondering how far i should separate the
>> core?  Should i just leave enough css that there is a sidebar, the header,
>> and the main content area?
>>
>
> Yes it sounds good.
>
> I agree it's difficult to arbitrate between what is "core" and what is
> style. I would tend to think that the core skin needs to have proper
> positionning, proper margins etc. and a good set of neutral defaults for
> colors, fonts and the rest. Then the actual xorange CSS overrides those
> defaults.
>
> This is an area I can help you test, I actually have already started
> implementing my own skin that derives xorange.
>
>
>
>> Thank you,
>> Jonathan Solichin
>>
>> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin
>> <[hidden email]>wrote:
>>
>>  I think that's a great idea, it would make the skin more extensible.
>>> Right
>>> now I am exploring creating a xar to create a page where there can be
>>> options-- right now for the colors, like you did with the "fluid" option
>>> on
>>> lyrebird.
>>>
>>> As I am separating the codes, i am wondering how far i should separate
>>> the
>>> core?  Should i just leave enough css that there is a sidebar, the
>>> header,
>>> and the main content area?
>>>
>>> Thank you,
>>> Jonathan Solichin
>>>
>>>
>>> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]
>>> >wrote:
>>>
>>>  Hi Jerome,
>>>>
>>>> All the advise you mentioned should now be fixed on github. Ajax search
>>>> is now implemented.
>>>>
>>>> I will be working on color themes, while still trying to ensure
>>>> consistency through out XE UI.
>>>>
>>>> Thank you again!
>>>> Jonathan Solichin
>>>>
>>>>
>>>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <
>>>> [hidden email]
>>>>
>>>>> wrote:
>>>>> Hello Friends,
>>>>>
>>>>> As you may or may not know, I have been working on a responsive skin
>>>>> for
>>>>> XWiki for GSOC (http://23.21.87.183:8080/**xwiki/bin/view/Main/WebHome<http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome>
>>>>> ).
>>>>> As I continue to add further details and refinements into the skin, I
>>>>> would
>>>>> like to kindly ask for your help in doing so. In order to make sure
>>>>> that I
>>>>> did not miss anything and the skin is as complete as possible, I would
>>>>> like
>>>>> to, if possible, request a XAR of an existing wiki (or complex pages)
>>>>> so
>>>>> that I may see the result of implementing the skin on more than the
>>>>> default
>>>>> wiki data.
>>>>>
>>>>> If this is not a possible, I would like to still enlist your help in
>>>>> testing some basic/your favorite functionality/features of xwiki.
>>>>> There are
>>>>> several ways to do this:
>>>>>
>>>>>     - By downloading the current skin and testing it on your XWiki:
>>>>>     https://github.com/jssolichin/**xo5<https://github.com/jssolichin/xo5>
>>>>>     - By playing around with the live instance (uses default admin
>>>>>     user/password): http://23.21.87.183:8080/**
>>>>> xwiki/bin/view/Main/WebHome<http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome>
>>>>>     - By letting me know of your favorite applications (so that I may
>>>>>     look into implementing them)
>>>>>
>>>>> Anything you want to note is fine. Bug and feature request are both
>>>>> welcome, as I think communal ideas are often better than one. Even if
>>>>> you
>>>>> did not have a chance to play too much with the skin, go ahead and let
>>>>> me
>>>>> know what you think I should check on (based on your experience) and/or
>>>>> give me any suggestions that may have come up while reading this.
>>>>> Technicality permitting, I will check myself.
>>>>>
>>>>> Helping with this process will help make the skin better, and maybe
>>>>> help
>>>>> it to be tailored to your (/type of) wiki and the community
>>>>> surrounding the
>>>>> platform in general.
>>>>>
>>>>> Thank you in advance for your time!
>>>>> Jonathan Solichin
>>>>>
>>>>>
>>>>  ______________________________**_________________
>> devs mailing list
>> [hidden email]
>> http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
>>
>
>
> --
> Peace,
> —Jerome
>
>
> ______________________________**_________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
On 07/31/2012 04:54 PM, Ecaterina Moraru (Valica) wrote:

> Hi Jonathan,
>
> Regarding the Skin testing - one solution would be to test it on incubator (
> http://incubator.myxwiki.org/) as long as you don't broke everything there
> (especially the Improvements space) :) but I guess a skin should be
> harmless, right? ;)
>
> Now some problems:
>
> After I logged in I really don't know what button to press in order to edit
> the Main.WebHome.
>
> Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that
> you choose to align them right. Our standard is vertical-aligned-left
> http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms
> I notice this on login page and on editing pages. This is easily fixable
> from CSS (.buttons class).

I think this ought to be skin specific. I take the standard as for the
officially maintained XE skin, a.k.a. colibri ; and think it would be
fair to say other skins could derive from it.
That said, I have a personnal preference for left-aligned or centered
buttons.

>
> You stripped all the CSS, so there will be lots of problems in lots of
> places. Maybe you should put back all the style dependencies.

I think Jonathan took inspiration from me on this one, this is what I've
done in Lyrebird.
To be honest, I think that pulling all style dependencies for
implementing a new skin is at least as hard as rewritting them all. Lots
of "component styles" (ex. search suggest, livetable, etc.) are in
reality tied to the visual codes of colibri (and sometimes even the
selectors are tied to colibri), and don't work well outside this scope.
The long term solution would be to have documented CSS components (a la
bootstrap for example) and DOM breakpoints (i.e. #mainContentArea, etc.
- this would also be useful in the event we implement generic interface
extensions as they were initially planned).

Now, there are some styles that could be pulled or copied over from
colibri. {{code}} macro styles are one example, but I'm sure there are
others.

> - You don't have any style for error boxes (
> http://23.21.87.183:8080/xwiki/bin/view/XWiki/OfficeImporter?&parent=XWiki.Admin).
> The style for info is not noticeable enough(looks very similar to table
> headers). The style used for warning is better suited for error macro.
> - The page -> Share by email feature is style-less.

Could it be because the app SSX has CSS selectors that don't match with
xorange DOM ?

> - .xform style for .xHint are gone (you can observe this when creating
> pages/spaces)
> - Administration -> ColorThemes can't be edited anymore in inline mode (the
> JS doesn't work)
> - Administration -> Panel Wizard is broken too
> - Administration -> Users, Groups (adding, editing, deleting users/groups)
> doesn't work
JS issue ? I think JSX are puled by xorange. Maybe there is a conflict
with other JS code from xorange...

> - Lots of sections in Administration are missing the styles + some portion
> of settings are displayed after the administration menu ends (Chrome) (you
> need to scroll in order to see all the options, see Administration ->
> Applications -> WYSIWYG Editor settings )

Same remark as for share by email

> - Problems with Blog posts in view and edit modes
> - Pages with few content look kind of strange :)
> http://23.21.87.183:8080/xwiki/bin/view/Sandbox/TestPage2 or
> http://23.21.87.183:8080/xwiki/bin/view/Main/CC
> - Some more left-right margins on content would be nice (looks crowded).
> 25px+ would work better than 10px margins on #xo-content
> - I like the Administration breadcrumb :p
> - I like how some forms look in edit mode :) like editing the Profile,
> although there are some issues with the sections H1
>
> Restyling the whole wiki is a big task and there are lots of things to do,
> but until now looks great.

It sure is :)

Thanks for your input Caty, very insightful.

Jerome

>
> Thanks for your work,
> Caty
>
> On Tue, Jul 31, 2012 at 11:52 AM, Jerome Velociter <[hidden email]>wrote:
>
>> On 07/30/2012 10:09 PM, Jonathan Solichin wrote:
>>
>>> I think that's a great idea, it would make the skin more extensible. Right
>>> now I am exploring creating a xar to create a page where there can be
>>> options-- right now for the colors, like you did with the "fluid" option
>>> on
>>> lyrebird.
>>>
>>> As I am separating the codes, i am wondering how far i should separate the
>>> core?  Should i just leave enough css that there is a sidebar, the header,
>>> and the main content area?
>>>
>> Yes it sounds good.
>>
>> I agree it's difficult to arbitrate between what is "core" and what is
>> style. I would tend to think that the core skin needs to have proper
>> positionning, proper margins etc. and a good set of neutral defaults for
>> colors, fonts and the rest. Then the actual xorange CSS overrides those
>> defaults.
>>
>> This is an area I can help you test, I actually have already started
>> implementing my own skin that derives xorange.
>>
>>
>>
>>> Thank you,
>>> Jonathan Solichin
>>>
>>> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin
>>> <[hidden email]>wrote:
>>>
>>>   I think that's a great idea, it would make the skin more extensible.
>>>> Right
>>>> now I am exploring creating a xar to create a page where there can be
>>>> options-- right now for the colors, like you did with the "fluid" option
>>>> on
>>>> lyrebird.
>>>>
>>>> As I am separating the codes, i am wondering how far i should separate
>>>> the
>>>> core?  Should i just leave enough css that there is a sidebar, the
>>>> header,
>>>> and the main content area?
>>>>
>>>> Thank you,
>>>> Jonathan Solichin
>>>>
>>>>
>>>> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]
>>>>> wrote:
>>>>   Hi Jerome,
>>>>> All the advise you mentioned should now be fixed on github. Ajax search
>>>>> is now implemented.
>>>>>
>>>>> I will be working on color themes, while still trying to ensure
>>>>> consistency through out XE UI.
>>>>>
>>>>> Thank you again!
>>>>> Jonathan Solichin
>>>>>
>>>>>
>>>>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <
>>>>> [hidden email]
>>>>>
>>>>>> wrote:
>>>>>> Hello Friends,
>>>>>>
>>>>>> As you may or may not know, I have been working on a responsive skin
>>>>>> for
>>>>>> XWiki for GSOC (http://23.21.87.183:8080/**xwiki/bin/view/Main/WebHome<http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome>
>>>>>> ).
>>>>>> As I continue to add further details and refinements into the skin, I
>>>>>> would
>>>>>> like to kindly ask for your help in doing so. In order to make sure
>>>>>> that I
>>>>>> did not miss anything and the skin is as complete as possible, I would
>>>>>> like
>>>>>> to, if possible, request a XAR of an existing wiki (or complex pages)
>>>>>> so
>>>>>> that I may see the result of implementing the skin on more than the
>>>>>> default
>>>>>> wiki data.
>>>>>>
>>>>>> If this is not a possible, I would like to still enlist your help in
>>>>>> testing some basic/your favorite functionality/features of xwiki.
>>>>>> There are
>>>>>> several ways to do this:
>>>>>>
>>>>>>      - By downloading the current skin and testing it on your XWiki:
>>>>>>      https://github.com/jssolichin/**xo5<https://github.com/jssolichin/xo5>
>>>>>>      - By playing around with the live instance (uses default admin
>>>>>>      user/password): http://23.21.87.183:8080/**
>>>>>> xwiki/bin/view/Main/WebHome<http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome>
>>>>>>      - By letting me know of your favorite applications (so that I may
>>>>>>      look into implementing them)
>>>>>>
>>>>>> Anything you want to note is fine. Bug and feature request are both
>>>>>> welcome, as I think communal ideas are often better than one. Even if
>>>>>> you
>>>>>> did not have a chance to play too much with the skin, go ahead and let
>>>>>> me
>>>>>> know what you think I should check on (based on your experience) and/or
>>>>>> give me any suggestions that may have come up while reading this.
>>>>>> Technicality permitting, I will check myself.
>>>>>>
>>>>>> Helping with this process will help make the skin better, and maybe
>>>>>> help
>>>>>> it to be tailored to your (/type of) wiki and the community
>>>>>> surrounding the
>>>>>> platform in general.
>>>>>>
>>>>>> Thank you in advance for your time!
>>>>>> Jonathan Solichin
>>>>>>
>>>>>>
>>>>>   ______________________________**_________________
>>> devs mailing list
>>> [hidden email]
>>> http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
>>>
>>
>> --
>> Peace,
>> —Jerome
>>
>>
>> ______________________________**_________________
>> devs mailing list
>> [hidden email]
>> http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
—Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
Hello Jerome, Caty,

First thank you again for the continual guidance.


> This is an area I can help you test, I actually have already started
> implementing my own skin that derives xorange.

If I may ask, what parts of the skin are you editing/deriving. It might
help to see what part people want to change.

After I logged in I really don't know what button to press in order to edit
> the Main.WebHome.

Apologies, I disabled that and forgot to turn it back on.

Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that
> you choose to align them right. Our standard is vertical-aligned-left
> http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms
> I notice this on login page and on editing pages. This is easily fixable
> from CSS (.buttons class).



> I think this ought to be skin specific. I take the standard as for the
> officially maintained XE skin, a.k.a. colibri ; and think it would be
> fair to say other skins could derive from it.
> That said, I have a personnal preference for left-aligned or centered
> buttons.

Thank you for bringing this to my attention. I have changed it to left
aligned now.

> You stripped all the CSS, so there will be lots of problems in lots of
> > places. Maybe you should put back all the style dependencies.
> I think Jonathan took inspiration from me on this one, this is what I've
> done in Lyrebird.
> To be honest, I think that pulling all style dependencies for
> implementing a new skin is at least as hard as rewritting them all. Lots
> of "component styles" (ex. search suggest, livetable, etc.) are in
> reality tied to the visual codes of colibri (and sometimes even the
> selectors are tied to colibri), and don't work well outside this scope.
> The long term solution would be to have documented CSS components (a la
> bootstrap for example) and DOM breakpoints (i.e. #mainContentArea, etc.
> - this would also be useful in the event we implement generic interface
> extensions as they were initially planned).
> Now, there are some styles that could be pulled or copied over from
> colibri. {{code}} macro styles are one example, but I'm sure there are
> others.

I agree it is a really big task. I was inspired by your lyrebird here. I
was wondering whether I should keep the default style. You can see that I
left some of the default styling at the bottom of my xwiki.css. One of the
hopes that I had to asking for other's input now that the majority of the
skin is finished, was to help me hunt down what I am missing (so thanks for
that). Presently I am hoping to style as much as I can/copy the
unstyled/derive, but maybe it is too big of a task, and I'll add in the
original css(s).

The style for info is not noticeable enough(looks very similar to table
> headers). The style used for warning is better suited for error macro.

Hmm, i was trying to keep it at a neutral color and keeping to the color
scheme of the skin (you're right it is the same color as the table header).
I was hoping that the fact that it goes beyond the padding of the rest of
content, and it's different background color would be visible enough yet
not distracting. Maybe if I add an icon (like back during the mockup) it
would help. And you're right, that is the wrong color choice, I fixed that
issue. Right now it is: gray for info, pale yellow for warning, and pale
red for error. I will play around with this.


> > - Administration -> ColorThemes can't be edited anymore in inline mode
> (the
> > JS doesn't work)
> > - Administration -> Panel Wizard is broken too
> > - Administration -> Users, Groups (adding, editing, deleting
> users/groups)
> > doesn't work
> JS issue ? I think JSX are puled by xorange. Maybe there is a conflict
> with other JS code from xorange...

you're right, it was a js conflict, thank you. I am not sure exactly which
one, but all these functions now work. xorange's startpage.vm is now
derived of colibri as well.

- Some more left-right margins on content would be nice (looks crowded).
> 25px+ would work better than 10px margins on #xo-content

I implemented a 30px padding now, but I am not sure how I feel about it. I
feel like it throws the skin of balance. Let me know if the change I made
is what you expected. Maybe someone can add more input on this? I am
definitely open to experimenting though, maybe I just need to get used to
it.


> - I like the Administration breadcrumb :p

Thank you.

- I like how some forms look in edit mode :) like editing the Profile,
> although there are some issues with the sections H1
> - Lots of sections in Administration are missing the styles + some portion
> of settings are displayed after the administration menu ends (Chrome) (you
> need to scroll in order to see all the options, see Administration ->
> Applications -> WYSIWYG Editor settings )

That is very interesting. I think these two points go hand in hand. I made
the form label float to the left of the text for styling purposes, which
causes issue when the label is too long (eg. the WYSIWYG editor setting).
It's going to be interesting to see if I can mediate between the two.

All the areas I did not address here, will be addressed soon. Thank you
again for helping me. And I would like to also say thanks for dropping by
Caty.

Best,
Jonathan Solichin

On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[hidden email]>wrote:

> I think that's a great idea, it would make the skin more extensible. Right
> now I am exploring creating a xar to create a page where there can be
> options-- right now for the colors, like you did with the "fluid" option on
> lyrebird.
>
> As I am separating the codes, i am wondering how far i should separate the
> core?  Should i just leave enough css that there is a sidebar, the header,
> and the main content area?
>
> Thank you,
> Jonathan Solichin
>
> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[hidden email]
> > wrote:
>
>> I think that's a great idea, it would make the skin more extensible.
>> Right now I am exploring creating a xar to create a page where there can be
>> options-- right now for the colors, like you did with the "fluid" option on
>> lyrebird.
>>
>> As I am separating the codes, i am wondering how far i should separate
>> the core?  Should i just leave enough css that there is a sidebar, the
>> header, and the main content area?
>>
>> Thank you,
>> Jonathan Solichin
>>
>>
>> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]>wrote:
>>
>>> Hi Jerome,
>>>
>>> All the advise you mentioned should now be fixed on github. Ajax search
>>> is now implemented.
>>>
>>> I will be working on color themes, while still trying to ensure
>>> consistency through out XE UI.
>>>
>>> Thank you again!
>>> Jonathan Solichin
>>>
>>>
>>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <
>>> [hidden email]> wrote:
>>>
>>>> Hello Friends,
>>>>
>>>> As you may or may not know, I have been working on a responsive skin
>>>> for XWiki for GSOC (
>>>> http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As I continue
>>>> to add further details and refinements into the skin, I would like to
>>>> kindly ask for your help in doing so. In order to make sure that I did not
>>>> miss anything and the skin is as complete as possible, I would like to, if
>>>> possible, request a XAR of an existing wiki (or complex pages) so that I
>>>> may see the result of implementing the skin on more than the default wiki
>>>> data.
>>>>
>>>> If this is not a possible, I would like to still enlist your help in
>>>> testing some basic/your favorite functionality/features of xwiki. There are
>>>> several ways to do this:
>>>>
>>>>    - By downloading the current skin and testing it on your XWiki:
>>>>    https://github.com/jssolichin/xo5
>>>>    - By playing around with the live instance (uses default admin
>>>>    user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>>>    - By letting me know of your favorite applications (so that I may
>>>>    look into implementing them)
>>>>
>>>> Anything you want to note is fine. Bug and feature request are both
>>>> welcome, as I think communal ideas are often better than one. Even if you
>>>> did not have a chance to play too much with the skin, go ahead and let me
>>>> know what you think I should check on (based on your experience) and/or
>>>> give me any suggestions that may have come up while reading this.
>>>> Technicality permitting, I will check myself.
>>>>
>>>> Helping with this process will help make the skin better, and maybe
>>>> help it to be tailored to your (/type of) wiki and the community
>>>> surrounding the platform in general.
>>>>
>>>> Thank you in advance for your time!
>>>> Jonathan Solichin
>>>>
>>>
>>>
>>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
Hello friends,

Beside yesterday's addition, these have also been addressed. I apologize if
you checked yesterday and the addition was not on github/live instance, I
uploaded the unchanged folder.

- Lots of sections in Administration are missing the styles + some portion
> of settings are displayed after the administration menu ends (Chrome) (you
> need to scroll in order to see all the options, see Administration ->
> Applications -> WYSIWYG Editor settings )


- .xform style for .xHint are gone (you can observe this when creating
> pages/spaces)

I just uploaded some stylings that makes this more eye pleasing and
responsive.

- The page -> Share by email feature is style-less.

Styled this as well

Thank you,
Jonathan Solichin
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
Hello friends,

I just updated the skin to allow the use of xwiki built in color themes. My
plan is to have a settings page that allows you to use xwiki color themes,
or use a preset color theme specifically made for xorange (eg. the original
one + maybe a couple more).

Beside this major change, most of the fixes mentioned earlier are
implemented (eg. blog skin and other miscellaneous fixes/skin improvements
(js, responsiveness etc.)).

I am still working on separating the core skin with the extra portion. I'm
still not sure of what part people might change, so I don't know where I
should draw the line. Any thoughts on this would be appreciated.

Thanks again everyone,
Jonathan Solichin

On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]>wrote:

> Hello friends,
>
> Beside yesterday's addition, these have also been addressed. I apologize
> if you checked yesterday and the addition was not on github/live instance,
> I uploaded the unchanged folder.
>
> - Lots of sections in Administration are missing the styles + some portion
>> of settings are displayed after the administration menu ends (Chrome)
>> (you
>> need to scroll in order to see all the options, see Administration ->
>> Applications -> WYSIWYG Editor settings )
>
>
> - .xform style for .xHint are gone (you can observe this when creating
>> pages/spaces)
>
> I just uploaded some stylings that makes this more eye pleasing and
> responsive.
>
> - The page -> Share by email feature is style-less.
>
> Styled this as well
>
> Thank you,
> Jonathan Solichin
>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Guillaume Lerouge
Hi Jonathan,

On Tue, Aug 7, 2012 at 10:21 AM, Jonathan Solichin <[hidden email]>wrote:

> Hello friends,
>
> I just updated the skin to allow the use of xwiki built in color themes. My
> plan is to have a settings page that allows you to use xwiki color themes,
> or use a preset color theme specifically made for xorange (eg. the original
> one + maybe a couple more).
>

If I understand correctly, note that this feature is already available in
the administration section of XWiki.

Guillaume

Beside this major change, most of the fixes mentioned earlier are

> implemented (eg. blog skin and other miscellaneous fixes/skin improvements
> (js, responsiveness etc.)).
>
> I am still working on separating the core skin with the extra portion. I'm
> still not sure of what part people might change, so I don't know where I
> should draw the line. Any thoughts on this would be appreciated.
>
> Thanks again everyone,
> Jonathan Solichin
>
> On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]
> >wrote:
>
> > Hello friends,
> >
> > Beside yesterday's addition, these have also been addressed. I apologize
> > if you checked yesterday and the addition was not on github/live
> instance,
> > I uploaded the unchanged folder.
> >
> > - Lots of sections in Administration are missing the styles + some
> portion
> >> of settings are displayed after the administration menu ends (Chrome)
> >> (you
> >> need to scroll in order to see all the options, see Administration ->
> >> Applications -> WYSIWYG Editor settings )
> >
> >
> > - .xform style for .xHint are gone (you can observe this when creating
> >> pages/spaces)
> >
> > I just uploaded some stylings that makes this more eye pleasing and
> > responsive.
> >
> > - The page -> Share by email feature is style-less.
> >
> > Styled this as well
> >
> > Thank you,
> > Jonathan Solichin
> >
> >
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
Hi Guillaume,

Thanks for dropping by. You are right, the feature is part of XWiki; the
skin is just now implemented to take advantage of it.

The reason I wanted to create a specific configuration page for the skin on
top of this is because some of the features/color styling that are in the
original skin are not part of XWiki's color theme. Eg. rgba color coding
(allows for changes in opacity), and h1-h6 color differentiation etc. Some
of the color themes available through xwiki are not very relevant to the
skin either. Eg. Gradients and so  forth.

The other option is to use all the colors on XWiki color theme, but it
might not be named correctly (eg. using button's  2nd gradient color as the
color for h4).

Let me know if that sort of addresses your concern, or whether you still
think there is a better way to go about this.

Thanks again!
Jonathan Solichin


On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[hidden email]>wrote:

> Hello friends,
>
> I just updated the skin to allow the use of xwiki built in color themes.
> My plan is to have a settings page that allows you to use xwiki color
> themes, or use a preset color theme specifically made for xorange (eg. the
> original one + maybe a couple more).
>
> Beside this major change, most of the fixes mentioned earlier are
> implemented (eg. blog skin and other miscellaneous fixes/skin improvements
> (js, responsiveness etc.)).
>
> I am still working on separating the core skin with the extra portion. I'm
> still not sure of what part people might change, so I don't know where I
> should draw the line. Any thoughts on this would be appreciated.
>
> Thanks again everyone,
> Jonathan Solichin
>
>
> On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hello friends,
>>
>> Beside yesterday's addition, these have also been addressed. I apologize
>> if you checked yesterday and the addition was not on github/live instance,
>> I uploaded the unchanged folder.
>>
>> - Lots of sections in Administration are missing the styles + some
>>> portion
>>> of settings are displayed after the administration menu ends (Chrome)
>>> (you
>>> need to scroll in order to see all the options, see Administration ->
>>> Applications -> WYSIWYG Editor settings )
>>
>>
>> - .xform style for .xHint are gone (you can observe this when creating
>>> pages/spaces)
>>
>> I just uploaded some stylings that makes this more eye pleasing and
>> responsive.
>>
>> - The page -> Share by email feature is style-less.
>>
>> Styled this as well
>>
>> Thank you,
>> Jonathan Solichin
>>
>>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Guillaume Lerouge
Hi Jonathan,

please see my answers below.

On Tue, Aug 7, 2012 at 8:38 PM, Jonathan Solichin <[hidden email]>wrote:

> Hi Guillaume,
>
> Thanks for dropping by. You are right, the feature is part of XWiki; the
> skin is just now implemented to take advantage of it.
>
> The reason I wanted to create a specific configuration page for the skin on
> top of this is because some of the features/color styling that are in the
> original skin are not part of XWiki's color theme. Eg. rgba color coding
> (allows for changes in opacity), and h1-h6 color differentiation etc. Some
> of the color themes available through xwiki are not very relevant to the
> skin either. Eg. Gradients and so  forth.
>

In that case the right solution would be to extend the color theme
mechanism in order for it to offer the additional values you need, not
adding a new configuration page :-)

Guillaume

The other option is to use all the colors on XWiki color theme, but it

> might not be named correctly (eg. using button's  2nd gradient color as the
> color for h4).
>
> Let me know if that sort of addresses your concern, or whether you still
> think there is a better way to go about this.
>
> Thanks again!
> Jonathan Solichin
>
>
> On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[hidden email]
> >wrote:
>
> > Hello friends,
> >
> > I just updated the skin to allow the use of xwiki built in color themes.
> > My plan is to have a settings page that allows you to use xwiki color
> > themes, or use a preset color theme specifically made for xorange (eg.
> the
> > original one + maybe a couple more).
> >
> > Beside this major change, most of the fixes mentioned earlier are
> > implemented (eg. blog skin and other miscellaneous fixes/skin
> improvements
> > (js, responsiveness etc.)).
> >
> > I am still working on separating the core skin with the extra portion.
> I'm
> > still not sure of what part people might change, so I don't know where I
> > should draw the line. Any thoughts on this would be appreciated.
> >
> > Thanks again everyone,
> > Jonathan Solichin
> >
> >
> > On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]
> >wrote:
> >
> >> Hello friends,
> >>
> >> Beside yesterday's addition, these have also been addressed. I apologize
> >> if you checked yesterday and the addition was not on github/live
> instance,
> >> I uploaded the unchanged folder.
> >>
> >> - Lots of sections in Administration are missing the styles + some
> >>> portion
> >>> of settings are displayed after the administration menu ends (Chrome)
> >>> (you
> >>> need to scroll in order to see all the options, see Administration ->
> >>> Applications -> WYSIWYG Editor settings )
> >>
> >>
> >> - .xform style for .xHint are gone (you can observe this when creating
> >>> pages/spaces)
> >>
> >> I just uploaded some stylings that makes this more eye pleasing and
> >> responsive.
> >>
> >> - The page -> Share by email feature is style-less.
> >>
> >> Styled this as well
> >>
> >> Thank you,
> >> Jonathan Solichin
> >>
> >>
> >
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
On 08/08/2012 10:57 AM, Guillaume Lerouge wrote:

> Hi Jonathan,
>
> please see my answers below.
>
> On Tue, Aug 7, 2012 at 8:38 PM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hi Guillaume,
>>
>> Thanks for dropping by. You are right, the feature is part of XWiki; the
>> skin is just now implemented to take advantage of it.
>>
>> The reason I wanted to create a specific configuration page for the skin on
>> top of this is because some of the features/color styling that are in the
>> original skin are not part of XWiki's color theme. Eg. rgba color coding
>> (allows for changes in opacity), and h1-h6 color differentiation etc. Some
>> of the color themes available through xwiki are not very relevant to the
>> skin either. Eg. Gradients and so  forth.
>>
> In that case the right solution would be to extend the color theme
> mechanism in order for it to offer the additional values you need, not
> adding a new configuration page :-)

I'm not so sure about that. Extending the official color theme
application is going to be a PITA for maintenance over the long term for
any skin not bundled and supported by the XWiki dev team.
It's one thing to use the color theme mechanism for preferences storage
of new skin-specific properties (but even that in my opinion doesn't
worth it) ; but extending the UI for managing those preferences is
another and I don't see that a viable solution right now.

Jerome

>
> Guillaume
>
> The other option is to use all the colors on XWiki color theme, but it
>> might not be named correctly (eg. using button's  2nd gradient color as the
>> color for h4).
>>
>> Let me know if that sort of addresses your concern, or whether you still
>> think there is a better way to go about this.
>>
>> Thanks again!
>> Jonathan Solichin
>>
>>
>> On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[hidden email]
>>> wrote:
>>> Hello friends,
>>>
>>> I just updated the skin to allow the use of xwiki built in color themes.
>>> My plan is to have a settings page that allows you to use xwiki color
>>> themes, or use a preset color theme specifically made for xorange (eg.
>> the
>>> original one + maybe a couple more).
>>>
>>> Beside this major change, most of the fixes mentioned earlier are
>>> implemented (eg. blog skin and other miscellaneous fixes/skin
>> improvements
>>> (js, responsiveness etc.)).
>>>
>>> I am still working on separating the core skin with the extra portion.
>> I'm
>>> still not sure of what part people might change, so I don't know where I
>>> should draw the line. Any thoughts on this would be appreciated.
>>>
>>> Thanks again everyone,
>>> Jonathan Solichin
>>>
>>>
>>> On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]
>>> wrote:
>>>
>>>> Hello friends,
>>>>
>>>> Beside yesterday's addition, these have also been addressed. I apologize
>>>> if you checked yesterday and the addition was not on github/live
>> instance,
>>>> I uploaded the unchanged folder.
>>>>
>>>> - Lots of sections in Administration are missing the styles + some
>>>>> portion
>>>>> of settings are displayed after the administration menu ends (Chrome)
>>>>> (you
>>>>> need to scroll in order to see all the options, see Administration ->
>>>>> Applications -> WYSIWYG Editor settings )
>>>>
>>>> - .xform style for .xHint are gone (you can observe this when creating
>>>>> pages/spaces)
>>>> I just uploaded some stylings that makes this more eye pleasing and
>>>> responsive.
>>>>
>>>> - The page -> Share by email feature is style-less.
>>>>
>>>> Styled this as well
>>>>
>>>> Thank you,
>>>> Jonathan Solichin
>>>>
>>>>
>> _______________________________________________
>> devs mailing list
>> [hidden email]
>> http://lists.xwiki.org/mailman/listinfo/devs
>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
—Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
In reply to this post by jssolichin
On 08/01/2012 12:34 PM, Jonathan Solichin wrote:
> Hello Jerome, Caty,
>
> First thank you again for the continual guidance.
>
>
>> This is an area I can help you test, I actually have already started
>> implementing my own skin that derives xorange.
> If I may ask, what parts of the skin are you editing/deriving. It might
> help to see what part people want to change.

Not final, but this is what I'm heading towards :
http://i.imgur.com/RSguA.png. The right part will behave just as xorange
sidebar in terms of responsiveness, so this is where deriving xorange
will be interesting.

I'm going to pull your latest work and work on giving you feedback
before the end of the week, both in terms of "extensibility" and with
regards to the lastest improvements you've committed.

Jerome

>
> After I logged in I really don't know what button to press in order to edit
>> the Main.WebHome.
> Apologies, I disabled that and forgot to turn it back on.
>
> Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that
>> you choose to align them right. Our standard is vertical-aligned-left
>> http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms
>> I notice this on login page and on editing pages. This is easily fixable
>> from CSS (.buttons class).
>
>
>> I think this ought to be skin specific. I take the standard as for the
>> officially maintained XE skin, a.k.a. colibri ; and think it would be
>> fair to say other skins could derive from it.
>> That said, I have a personnal preference for left-aligned or centered
>> buttons.
> Thank you for bringing this to my attention. I have changed it to left
> aligned now.
>
>> You stripped all the CSS, so there will be lots of problems in lots of
>>> places. Maybe you should put back all the style dependencies.
>> I think Jonathan took inspiration from me on this one, this is what I've
>> done in Lyrebird.
>> To be honest, I think that pulling all style dependencies for
>> implementing a new skin is at least as hard as rewritting them all. Lots
>> of "component styles" (ex. search suggest, livetable, etc.) are in
>> reality tied to the visual codes of colibri (and sometimes even the
>> selectors are tied to colibri), and don't work well outside this scope.
>> The long term solution would be to have documented CSS components (a la
>> bootstrap for example) and DOM breakpoints (i.e. #mainContentArea, etc.
>> - this would also be useful in the event we implement generic interface
>> extensions as they were initially planned).
>> Now, there are some styles that could be pulled or copied over from
>> colibri. {{code}} macro styles are one example, but I'm sure there are
>> others.
> I agree it is a really big task. I was inspired by your lyrebird here. I
> was wondering whether I should keep the default style. You can see that I
> left some of the default styling at the bottom of my xwiki.css. One of the
> hopes that I had to asking for other's input now that the majority of the
> skin is finished, was to help me hunt down what I am missing (so thanks for
> that). Presently I am hoping to style as much as I can/copy the
> unstyled/derive, but maybe it is too big of a task, and I'll add in the
> original css(s).
>
> The style for info is not noticeable enough(looks very similar to table
>> headers). The style used for warning is better suited for error macro.
> Hmm, i was trying to keep it at a neutral color and keeping to the color
> scheme of the skin (you're right it is the same color as the table header).
> I was hoping that the fact that it goes beyond the padding of the rest of
> content, and it's different background color would be visible enough yet
> not distracting. Maybe if I add an icon (like back during the mockup) it
> would help. And you're right, that is the wrong color choice, I fixed that
> issue. Right now it is: gray for info, pale yellow for warning, and pale
> red for error. I will play around with this.
>
>
>>> - Administration -> ColorThemes can't be edited anymore in inline mode
>> (the
>>> JS doesn't work)
>>> - Administration -> Panel Wizard is broken too
>>> - Administration -> Users, Groups (adding, editing, deleting
>> users/groups)
>>> doesn't work
>> JS issue ? I think JSX are puled by xorange. Maybe there is a conflict
>> with other JS code from xorange...
> you're right, it was a js conflict, thank you. I am not sure exactly which
> one, but all these functions now work. xorange's startpage.vm is now
> derived of colibri as well.
>
> - Some more left-right margins on content would be nice (looks crowded).
>> 25px+ would work better than 10px margins on #xo-content
> I implemented a 30px padding now, but I am not sure how I feel about it. I
> feel like it throws the skin of balance. Let me know if the change I made
> is what you expected. Maybe someone can add more input on this? I am
> definitely open to experimenting though, maybe I just need to get used to
> it.
>
>
>> - I like the Administration breadcrumb :p
> Thank you.
>
> - I like how some forms look in edit mode :) like editing the Profile,
>> although there are some issues with the sections H1
>> - Lots of sections in Administration are missing the styles + some portion
>> of settings are displayed after the administration menu ends (Chrome) (you
>> need to scroll in order to see all the options, see Administration ->
>> Applications -> WYSIWYG Editor settings )
> That is very interesting. I think these two points go hand in hand. I made
> the form label float to the left of the text for styling purposes, which
> causes issue when the label is too long (eg. the WYSIWYG editor setting).
> It's going to be interesting to see if I can mediate between the two.
>
> All the areas I did not address here, will be addressed soon. Thank you
> again for helping me. And I would like to also say thanks for dropping by
> Caty.
>
> Best,
> Jonathan Solichin
>
> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[hidden email]>wrote:
>
>> I think that's a great idea, it would make the skin more extensible. Right
>> now I am exploring creating a xar to create a page where there can be
>> options-- right now for the colors, like you did with the "fluid" option on
>> lyrebird.
>>
>> As I am separating the codes, i am wondering how far i should separate the
>> core?  Should i just leave enough css that there is a sidebar, the header,
>> and the main content area?
>>
>> Thank you,
>> Jonathan Solichin
>>
>> On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[hidden email]
>>> wrote:
>>> I think that's a great idea, it would make the skin more extensible.
>>> Right now I am exploring creating a xar to create a page where there can be
>>> options-- right now for the colors, like you did with the "fluid" option on
>>> lyrebird.
>>>
>>> As I am separating the codes, i am wondering how far i should separate
>>> the core?  Should i just leave enough css that there is a sidebar, the
>>> header, and the main content area?
>>>
>>> Thank you,
>>> Jonathan Solichin
>>>
>>>
>>> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <[hidden email]>wrote:
>>>
>>>> Hi Jerome,
>>>>
>>>> All the advise you mentioned should now be fixed on github. Ajax search
>>>> is now implemented.
>>>>
>>>> I will be working on color themes, while still trying to ensure
>>>> consistency through out XE UI.
>>>>
>>>> Thank you again!
>>>> Jonathan Solichin
>>>>
>>>>
>>>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <
>>>> [hidden email]> wrote:
>>>>
>>>>> Hello Friends,
>>>>>
>>>>> As you may or may not know, I have been working on a responsive skin
>>>>> for XWiki for GSOC (
>>>>> http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As I continue
>>>>> to add further details and refinements into the skin, I would like to
>>>>> kindly ask for your help in doing so. In order to make sure that I did not
>>>>> miss anything and the skin is as complete as possible, I would like to, if
>>>>> possible, request a XAR of an existing wiki (or complex pages) so that I
>>>>> may see the result of implementing the skin on more than the default wiki
>>>>> data.
>>>>>
>>>>> If this is not a possible, I would like to still enlist your help in
>>>>> testing some basic/your favorite functionality/features of xwiki. There are
>>>>> several ways to do this:
>>>>>
>>>>>     - By downloading the current skin and testing it on your XWiki:
>>>>>     https://github.com/jssolichin/xo5
>>>>>     - By playing around with the live instance (uses default admin
>>>>>     user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome
>>>>>     - By letting me know of your favorite applications (so that I may
>>>>>     look into implementing them)
>>>>>
>>>>> Anything you want to note is fine. Bug and feature request are both
>>>>> welcome, as I think communal ideas are often better than one. Even if you
>>>>> did not have a chance to play too much with the skin, go ahead and let me
>>>>> know what you think I should check on (based on your experience) and/or
>>>>> give me any suggestions that may have come up while reading this.
>>>>> Technicality permitting, I will check myself.
>>>>>
>>>>> Helping with this process will help make the skin better, and maybe
>>>>> help it to be tailored to your (/type of) wiki and the community
>>>>> surrounding the platform in general.
>>>>>
>>>>> Thank you in advance for your time!
>>>>> Jonathan Solichin
>>>>>
>>>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
---Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

jssolichin
In reply to this post by jssolichin
>
> In that case the right solution would be to extend the color theme
> mechanism in order for it to offer the additional values you need, not
> adding a new configuration page :-)


I'm not so sure about that. Extending the official color theme
> application is going to be a PITA for maintenance over the long term for
> any skin not bundled and supported by the XWiki dev team.
> It's one thing to use the color theme mechanism for preferences storage
> of new skin-specific properties (but even that in my opinion doesn't
> worth it) ; but extending the UI for managing those preferences is
> another and I don't see that a viable solution right now.

Ok thank you for the thoughts. As per these advice, I will stop that plan.
The skin works and looks fine without it. I just thought it might be
interesting to add, but it is in no way unnecessary.

Not final, but this is what I'm heading towards :
> http://i.imgur.com/RSguA.png. The right part will behave just as xorange
> sidebar in terms of responsiveness, so this is where deriving xorange
> will be interesting.

It seems that the primary focus to keep is the sidebar? correct me if I am
wrong on this.

I went ahead an tried an attempt to separate. If you pull from github now,
there will be a style.css (core), an xwiki.css (the extension), and a new
src folder that has the two css line by line where it is divided. The first
line of style.css is @import to xwiki.css, so if you wish to not pull the
additional styling, you can just comment this line out (should i make a
configuration page that does this, or is this too trivial?)

The way i went about the dividing was to try and cut out all the
typography, padding/margin and etc. I left behind some of the style intact
because I felt like they were pretty integral to how the skin works. Eg.
the sidebar is almost completely untouch, and the dropdown is left in. Let
me know what you think of this division, and whether I should try to
separate more.

Thanks!
Jonathan Solichin

On Tue, Aug 7, 2012 at 11:38 AM, Jonathan Solichin <[hidden email]>wrote:

> Hi Guillaume,
>
>  Thanks for dropping by. You are right, the feature is part of XWiki; the
> skin is just now implemented to take advantage of it.
>
> The reason I wanted to create a specific configuration page for the skin
> on top of this is because some of the features/color styling that are in
> the original skin are not part of XWiki's color theme. Eg. rgba color
> coding (allows for changes in opacity), and h1-h6 color differentiation
> etc. Some of the color themes available through xwiki are not very relevant
> to the skin either. Eg. Gradients and so  forth.
>
> The other option is to use all the colors on XWiki color theme, but it
> might not be named correctly (eg. using button's  2nd gradient color as the
> color for h4).
>
> Let me know if that sort of addresses your concern, or whether you still
> think there is a better way to go about this.
>
> Thanks again!
> Jonathan Solichin
>
>
> On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hello friends,
>>
>> I just updated the skin to allow the use of xwiki built in color themes.
>> My plan is to have a settings page that allows you to use xwiki color
>> themes, or use a preset color theme specifically made for xorange (eg. the
>> original one + maybe a couple more).
>>
>> Beside this major change, most of the fixes mentioned earlier are
>> implemented (eg. blog skin and other miscellaneous fixes/skin improvements
>> (js, responsiveness etc.)).
>>
>> I am still working on separating the core skin with the extra portion.
>> I'm still not sure of what part people might change, so I don't know where
>> I should draw the line. Any thoughts on this would be appreciated.
>>
>> Thanks again everyone,
>> Jonathan Solichin
>>
>>
>> On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]>wrote:
>>
>>> Hello friends,
>>>
>>> Beside yesterday's addition, these have also been addressed. I apologize
>>> if you checked yesterday and the addition was not on github/live instance,
>>> I uploaded the unchanged folder.
>>>
>>> - Lots of sections in Administration are missing the styles + some
>>>> portion
>>>> of settings are displayed after the administration menu ends (Chrome)
>>>> (you
>>>> need to scroll in order to see all the options, see Administration ->
>>>> Applications -> WYSIWYG Editor settings )
>>>
>>>
>>> - .xform style for .xHint are gone (you can observe this when creating
>>>> pages/spaces)
>>>
>>> I just uploaded some stylings that makes this more eye pleasing and
>>> responsive.
>>>
>>> - The page -> Share by email feature is style-less.
>>>
>>> Styled this as well
>>>
>>> Thank you,
>>> Jonathan Solichin
>>>
>>>
>>
>
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [GSoC] [Request] Responsive Skin - data for extensive testing/bug finds/feature requests

Jérôme Velociter
On 08/09/2012 10:47 AM, Jonathan Solichin wrote:

>> In that case the right solution would be to extend the color theme
>> mechanism in order for it to offer the additional values you need, not
>> adding a new configuration page :-)
>
> I'm not so sure about that. Extending the official color theme
>> application is going to be a PITA for maintenance over the long term for
>> any skin not bundled and supported by the XWiki dev team.
>> It's one thing to use the color theme mechanism for preferences storage
>> of new skin-specific properties (but even that in my opinion doesn't
>> worth it) ; but extending the UI for managing those preferences is
>> another and I don't see that a viable solution right now.
> Ok thank you for the thoughts. As per these advice, I will stop that plan.
> The skin works and looks fine without it. I just thought it might be
> interesting to add, but it is in no way unnecessary.

Don't get me wrong, I didn't meant to stop you from making the skin
themeable (if that's what you meant). I just think that integrating the
theme configuration with the bundled color theme app is likely to be a
wasted effort in the long run, because the app is tied to colibri and
doesn't offer a mechanism to support skin-specific configurations. (like
would be for xorange "sidebar length", or breakpoints properties etc.)

Making it themeable is great :)

>
> Not final, but this is what I'm heading towards :
>> http://i.imgur.com/RSguA.png. The right part will behave just as xorange
>> sidebar in terms of responsiveness, so this is where deriving xorange
>> will be interesting.
> It seems that the primary focus to keep is the sidebar? correct me if I am
> wrong on this.

Exactly

>
> I went ahead an tried an attempt to separate. If you pull from github now,
> there will be a style.css (core), an xwiki.css (the extension), and a new
> src folder that has the two css line by line where it is divided. The first
> line of style.css is @import to xwiki.css, so if you wish to not pull the
> additional styling, you can just comment this line out (should i make a
> configuration page that does this, or is this too trivial?)
>
> The way i went about the dividing was to try and cut out all the
> typography, padding/margin and etc. I left behind some of the style intact
> because I felt like they were pretty integral to how the skin works. Eg.
> the sidebar is almost completely untouch, and the dropdown is left in. Let
> me know what you think of this division, and whether I should try to
> separate more.

I will give it a try.

Jerome

>
> Thanks!
> Jonathan Solichin
>
> On Tue, Aug 7, 2012 at 11:38 AM, Jonathan Solichin <[hidden email]>wrote:
>
>> Hi Guillaume,
>>
>>   Thanks for dropping by. You are right, the feature is part of XWiki; the
>> skin is just now implemented to take advantage of it.
>>
>> The reason I wanted to create a specific configuration page for the skin
>> on top of this is because some of the features/color styling that are in
>> the original skin are not part of XWiki's color theme. Eg. rgba color
>> coding (allows for changes in opacity), and h1-h6 color differentiation
>> etc. Some of the color themes available through xwiki are not very relevant
>> to the skin either. Eg. Gradients and so  forth.
>>
>> The other option is to use all the colors on XWiki color theme, but it
>> might not be named correctly (eg. using button's  2nd gradient color as the
>> color for h4).
>>
>> Let me know if that sort of addresses your concern, or whether you still
>> think there is a better way to go about this.
>>
>> Thanks again!
>> Jonathan Solichin
>>
>>
>> On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[hidden email]>wrote:
>>
>>> Hello friends,
>>>
>>> I just updated the skin to allow the use of xwiki built in color themes.
>>> My plan is to have a settings page that allows you to use xwiki color
>>> themes, or use a preset color theme specifically made for xorange (eg. the
>>> original one + maybe a couple more).
>>>
>>> Beside this major change, most of the fixes mentioned earlier are
>>> implemented (eg. blog skin and other miscellaneous fixes/skin improvements
>>> (js, responsiveness etc.)).
>>>
>>> I am still working on separating the core skin with the extra portion.
>>> I'm still not sure of what part people might change, so I don't know where
>>> I should draw the line. Any thoughts on this would be appreciated.
>>>
>>> Thanks again everyone,
>>> Jonathan Solichin
>>>
>>>
>>> On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[hidden email]>wrote:
>>>
>>>> Hello friends,
>>>>
>>>> Beside yesterday's addition, these have also been addressed. I apologize
>>>> if you checked yesterday and the addition was not on github/live instance,
>>>> I uploaded the unchanged folder.
>>>>
>>>> - Lots of sections in Administration are missing the styles + some
>>>>> portion
>>>>> of settings are displayed after the administration menu ends (Chrome)
>>>>> (you
>>>>> need to scroll in order to see all the options, see Administration ->
>>>>> Applications -> WYSIWYG Editor settings )
>>>>
>>>> - .xform style for .xHint are gone (you can observe this when creating
>>>>> pages/spaces)
>>>> I just uploaded some stylings that makes this more eye pleasing and
>>>> responsive.
>>>>
>>>> - The page -> Share by email feature is style-less.
>>>>
>>>> Styled this as well
>>>>
>>>> Thank you,
>>>> Jonathan Solichin
>>>>
>>>>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs


--
Peace,
—Jerome

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
12