[GSoC] [coding sample Jira issues]

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GSoC] [coding sample Jira issues]

Krzysiek Płachno
Hello,

I want to do some JIRA task as a part of my application for GSoC. I
encountered some doubts.

1. I asked questions in comments in 2 issues. Is it the proper way of
discussing them or should I ask about them on mailing list?
Links to those issues:
https://jira.xwiki.org/browse/XWIKI-13496?filter=10534
https://jira.xwiki.org/browse/XWIKI-12704?filter=10534

2. When I do fixes on my local repository and I want to create Pull Request
I need to upload them to one of remote branches - typically branch created
specially for my fix, right? It seems that option of creation branches on
github is disabled for externals like me. How can I upload my fixes and
create PR, then?

3. I've searched dev guides and also names of created branches on github.
What's the convention for proper naming of bugfix or feature branches?
Examples that I found are following: "feature-XWIKI-12544",
"feature-alfresco-link" or simply id of ticket: "XWIKI-7553"

I know that I sit down to coding a bit late, but I hope I'll manage do
upload at least one Pull Request before deadline.

Best,
Krzysiek

P.S. I haven't encountered any Java project so far in which the code
convention was to put opening curl bracket '{' in new line :)
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GSoC] [coding sample Jira issues]

Thomas Mortagne
Administrator
On Sun, Apr 2, 2017 at 2:02 PM, Krzysiek Płachno
<[hidden email]> wrote:

> Hello,
>
> I want to do some JIRA task as a part of my application for GSoC. I
> encountered some doubts.
>
> 1. I asked questions in comments in 2 issues. Is it the proper way of
> discussing them or should I ask about them on mailing list?
> Links to those issues:
> https://jira.xwiki.org/browse/XWIKI-13496?filter=10534
> https://jira.xwiki.org/browse/XWIKI-12704?filter=10534

It's the right way but weekend is not the most active part of the week
around here :)

I will look at that and try to think of other issues that might be
interesting for you.

>
> 2. When I do fixes on my local repository and I want to create Pull Request
> I need to upload them to one of remote branches - typically branch created
> specially for my fix, right? It seems that option of creation branches on
> github is disabled for externals like me. How can I upload my fixes and
> create PR, then?

You need to "fork" the reposirory to want to work on, then you create
branches in your fork and create pull request from those branches
(github will automatically see it's a fork and propose pull request to
the source reposirory).

>
> 3. I've searched dev guides and also names of created branches on github.
> What's the convention for proper naming of bugfix or feature branches?
> Examples that I found are following: "feature-XWIKI-12544",
> "feature-alfresco-link" or simply id of ticket: "XWIKI-7553"

The branch will be on your fork so it does not matter much but the
naming convention on root repository right now is
"feature-<whateverouwant>".

>
> I know that I sit down to coding a bit late, but I hope I'll manage do
> upload at least one Pull Request before deadline.
>
> Best,
> Krzysiek
>

> P.S. I haven't encountered any Java project so far in which the code
> convention was to put opening curl bracket '{' in new line :)

That's only for methods actually :)

--
Thomas Mortagne
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GSoC] [coding sample Jira issues]

Thomas Mortagne
Administrator
By the way don't forget to make your proposal final since the deadline is today.

On Mon, Apr 3, 2017 at 9:01 AM, Thomas Mortagne
<[hidden email]> wrote:

> On Sun, Apr 2, 2017 at 2:02 PM, Krzysiek Płachno
> <[hidden email]> wrote:
>> Hello,
>>
>> I want to do some JIRA task as a part of my application for GSoC. I
>> encountered some doubts.
>>
>> 1. I asked questions in comments in 2 issues. Is it the proper way of
>> discussing them or should I ask about them on mailing list?
>> Links to those issues:
>> https://jira.xwiki.org/browse/XWIKI-13496?filter=10534
>> https://jira.xwiki.org/browse/XWIKI-12704?filter=10534
>
> It's the right way but weekend is not the most active part of the week
> around here :)
>
> I will look at that and try to think of other issues that might be
> interesting for you.
>
>>
>> 2. When I do fixes on my local repository and I want to create Pull Request
>> I need to upload them to one of remote branches - typically branch created
>> specially for my fix, right? It seems that option of creation branches on
>> github is disabled for externals like me. How can I upload my fixes and
>> create PR, then?
>
> You need to "fork" the reposirory to want to work on, then you create
> branches in your fork and create pull request from those branches
> (github will automatically see it's a fork and propose pull request to
> the source reposirory).
>
>>
>> 3. I've searched dev guides and also names of created branches on github.
>> What's the convention for proper naming of bugfix or feature branches?
>> Examples that I found are following: "feature-XWIKI-12544",
>> "feature-alfresco-link" or simply id of ticket: "XWIKI-7553"
>
> The branch will be on your fork so it does not matter much but the
> naming convention on root repository right now is
> "feature-<whateverouwant>".
>
>>
>> I know that I sit down to coding a bit late, but I hope I'll manage do
>> upload at least one Pull Request before deadline.
>>
>> Best,
>> Krzysiek
>>
>
>> P.S. I haven't encountered any Java project so far in which the code
>> convention was to put opening curl bracket '{' in new line :)
>
> That's only for methods actually :)
>
> --
> Thomas Mortagne



--
Thomas Mortagne
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GSoC] [coding sample Jira issues]

Krzysiek Płachno
Thanks for response!
Yes, I know, deadline is today :)

Best,
Krzysiek

2017-04-03 10:27 GMT+02:00 Thomas Mortagne <[hidden email]>:

> By the way don't forget to make your proposal final since the deadline is
> today.
>
> On Mon, Apr 3, 2017 at 9:01 AM, Thomas Mortagne
> <[hidden email]> wrote:
> > On Sun, Apr 2, 2017 at 2:02 PM, Krzysiek Płachno
> > <[hidden email]> wrote:
> >> Hello,
> >>
> >> I want to do some JIRA task as a part of my application for GSoC. I
> >> encountered some doubts.
> >>
> >> 1. I asked questions in comments in 2 issues. Is it the proper way of
> >> discussing them or should I ask about them on mailing list?
> >> Links to those issues:
> >> https://jira.xwiki.org/browse/XWIKI-13496?filter=10534
> >> https://jira.xwiki.org/browse/XWIKI-12704?filter=10534
> >
> > It's the right way but weekend is not the most active part of the week
> > around here :)
> >
> > I will look at that and try to think of other issues that might be
> > interesting for you.
> >
> >>
> >> 2. When I do fixes on my local repository and I want to create Pull
> Request
> >> I need to upload them to one of remote branches - typically branch
> created
> >> specially for my fix, right? It seems that option of creation branches
> on
> >> github is disabled for externals like me. How can I upload my fixes and
> >> create PR, then?
> >
> > You need to "fork" the reposirory to want to work on, then you create
> > branches in your fork and create pull request from those branches
> > (github will automatically see it's a fork and propose pull request to
> > the source reposirory).
> >
> >>
> >> 3. I've searched dev guides and also names of created branches on
> github.
> >> What's the convention for proper naming of bugfix or feature branches?
> >> Examples that I found are following: "feature-XWIKI-12544",
> >> "feature-alfresco-link" or simply id of ticket: "XWIKI-7553"
> >
> > The branch will be on your fork so it does not matter much but the
> > naming convention on root repository right now is
> > "feature-<whateverouwant>".
> >
> >>
> >> I know that I sit down to coding a bit late, but I hope I'll manage do
> >> upload at least one Pull Request before deadline.
> >>
> >> Best,
> >> Krzysiek
> >>
> >
> >> P.S. I haven't encountered any Java project so far in which the code
> >> convention was to put opening curl bracket '{' in new line :)
> >
> > That's only for methods actually :)
> >
> > --
> > Thomas Mortagne
>
>
>
> --
> Thomas Mortagne
>
Loading...