Re: [Issue] Created: (XWIKI-2116) Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Issue] Created: (XWIKI-2116) Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.

ebullient
I was asked to post to the list about this.. things have been busy, so
it's taken me awhile.

There are a few things that really bug me about the XWikiAllGroup:

1) It requires an XWikiGroups object to be created for every
registered user, which is a pain in the butt when there are thousands
2) It is possible for the XWikiAllGroup to get out of sync with actual
registered users: When users are deleted, it does not automatically
remove the corresponding object from XWikiAllGroup, and if there is a
strange window with the cache (which I've seen happen) objects for new
users are not correctly added to the XWikiAllGroup document.

The XWikiAllGroup is special (just as XWikiGuest is special). It's my
view that the document a) shouldn't have to really exist, and b)
shouldn't actually have to have XWikiGroups objects for every user
attached to it.  If someone is a valid user, they're in
XWikiAllGroup.. that's it.  The default contents of the XWikiAllGroup
document could either be a link to the XWikiUsers page, or a repeat of
the query displaying all of the users in the system.

So it's my thought that the auth code should be modified to treat
XWikiAllGroup as a special entity in the future.  I know I'll be more
than happy to delete the XWiki.XWikiAllGroup document as soon as I
have the chance.




On Wed, Feb 13, 2008 at 11:32 PM, Erin Schnabel (JIRA) <[hidden email]> wrote:

> Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.
>  ----------------------------------------------------------------------------------------------
>
>                  Key: XWIKI-2116
>                  URL: http://jira.xwiki.org/jira/browse/XWIKI-2116
>              Project: XWiki Core
>           Issue Type: Bug
>           Components: Authentication and Rights Management
>     Affects Versions: 1.2.1, 1.2, 1.1, 1.0
>             Reporter: Erin Schnabel
>
>
>  I've seen XWiki.XWikiAllGroup get out of sync: There are users in XWIki.XWikiAllGroup that don't exist, and users that exist that aren't in XWIki.XWikiAllGroup.
>
>  It seems to me that XWiki.XWikiAllGroup is special.  It should be treated in auth code as a magic word, like superadmin or XWiki.XWikiGuest, to mean "any user that exists in the DB for that wiki"  (XWikiGuest doesn't live in the DB.. ).
>
>  These "AllGroups" would still hold different members:   xwiki:XWiki.XWikiAllGroup, xwiki_virtual:XWiki.XWikiAllGroup
>
>  --
>  This message is automatically generated by JIRA.
>  -
>  If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
>  -
>  For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>



--
'Waste of a good apple' -Samwise Gamgee
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [Issue] Created: (XWIKI-2116) Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.

Thomas Mortagne
Administrator
Hi,

On Wed, Mar 12, 2008 at 7:26 PM, Erin Schnabel <[hidden email]> wrote:

> I was asked to post to the list about this.. things have been busy, so
>  it's taken me awhile.
>
>  There are a few things that really bug me about the XWikiAllGroup:
>
>  1) It requires an XWikiGroups object to be created for every
>  registered user, which is a pain in the butt when there are thousands
>  2) It is possible for the XWikiAllGroup to get out of sync with actual
>  registered users: When users are deleted, it does not automatically
>  remove the corresponding object from XWikiAllGroup, and if there is a
>  strange window with the cache (which I've seen happen) objects for new
>  users are not correctly added to the XWikiAllGroup document.

RightsManager plugin (included in the core) should take care of
cleaning groups when user is removed, if it does not : you xwiki is
older than 1.2, rightsmanager plugin is not enabled in the xwiki.cfg
(it is by default) or there is a bug.

Anyway i totally agree with you, for me XWikiAllGroup should be a
"virtual" group. It was just a comment ;)

>
>  The XWikiAllGroup is special (just as XWikiGuest is special). It's my
>  view that the document a) shouldn't have to really exist, and b)
>  shouldn't actually have to have XWikiGroups objects for every user
>  attached to it.  If someone is a valid user, they're in
>  XWikiAllGroup.. that's it.  The default contents of the XWikiAllGroup
>  document could either be a link to the XWikiUsers page, or a repeat of
>  the query displaying all of the users in the system.
>
>  So it's my thought that the auth code should be modified to treat
>  XWikiAllGroup as a special entity in the future.  I know I'll be more
>  than happy to delete the XWiki.XWikiAllGroup document as soon as I
>  have the chance.
>
>
>
>
>  On Wed, Feb 13, 2008 at 11:32 PM, Erin Schnabel (JIRA) <[hidden email]> wrote:
>  > Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.
>  >  ----------------------------------------------------------------------------------------------
>  >
>  >                  Key: XWIKI-2116
>  >                  URL: http://jira.xwiki.org/jira/browse/XWIKI-2116
>  >              Project: XWiki Core
>  >           Issue Type: Bug
>  >           Components: Authentication and Rights Management
>  >     Affects Versions: 1.2.1, 1.2, 1.1, 1.0
>  >             Reporter: Erin Schnabel
>  >
>  >
>  >  I've seen XWiki.XWikiAllGroup get out of sync: There are users in XWIki.XWikiAllGroup that don't exist, and users that exist that aren't in XWIki.XWikiAllGroup.
>  >
>  >  It seems to me that XWiki.XWikiAllGroup is special.  It should be treated in auth code as a magic word, like superadmin or XWiki.XWikiGuest, to mean "any user that exists in the DB for that wiki"  (XWikiGuest doesn't live in the DB.. ).
>  >
>  >  These "AllGroups" would still hold different members:   xwiki:XWiki.XWikiAllGroup, xwiki_virtual:XWiki.XWikiAllGroup
>  >
>  >  --
>  >  This message is automatically generated by JIRA.
>  >  -
>  >  If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
>  >  -
>  >  For more information on JIRA, see: http://www.atlassian.com/software/jira
>  >
>  >
>  >
>
>
>
>  --
>  'Waste of a good apple' -Samwise Gamgee
>  _______________________________________________
>  devs mailing list
>  [hidden email]
>  http://lists.xwiki.org/mailman/listinfo/devs
>



--
Thomas Mortagne
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs
Reply | Threaded
Open this post in threaded view
|

Re: [Issue] Created: (XWIKI-2116) Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.

Ludovic Dubost-2
In reply to this post by ebullient

+1 to make XWikiAllGroup a special group. It should have been like that
right away.
We could either make it a special group or create virtual groups (based
on queries).

Ludovic

Erin Schnabel wrote:

> I was asked to post to the list about this.. things have been busy, so
> it's taken me awhile.
>
> There are a few things that really bug me about the XWikiAllGroup:
>
> 1) It requires an XWikiGroups object to be created for every
> registered user, which is a pain in the butt when there are thousands
> 2) It is possible for the XWikiAllGroup to get out of sync with actual
> registered users: When users are deleted, it does not automatically
> remove the corresponding object from XWikiAllGroup, and if there is a
> strange window with the cache (which I've seen happen) objects for new
> users are not correctly added to the XWikiAllGroup document.
>
> The XWikiAllGroup is special (just as XWikiGuest is special). It's my
> view that the document a) shouldn't have to really exist, and b)
> shouldn't actually have to have XWikiGroups objects for every user
> attached to it.  If someone is a valid user, they're in
> XWikiAllGroup.. that's it.  The default contents of the XWikiAllGroup
> document could either be a link to the XWikiUsers page, or a repeat of
> the query displaying all of the users in the system.
>
> So it's my thought that the auth code should be modified to treat
> XWikiAllGroup as a special entity in the future.  I know I'll be more
> than happy to delete the XWiki.XWikiAllGroup document as soon as I
> have the chance.
>
>
>
>
> On Wed, Feb 13, 2008 at 11:32 PM, Erin Schnabel (JIRA) <[hidden email]> wrote:
>  
>> Make XWiki.XWikiAllGroup a "special" group, rather than a real document with objects attached.
>>  ----------------------------------------------------------------------------------------------
>>
>>                  Key: XWIKI-2116
>>                  URL: http://jira.xwiki.org/jira/browse/XWIKI-2116
>>              Project: XWiki Core
>>           Issue Type: Bug
>>           Components: Authentication and Rights Management
>>     Affects Versions: 1.2.1, 1.2, 1.1, 1.0
>>             Reporter: Erin Schnabel
>>
>>
>>  I've seen XWiki.XWikiAllGroup get out of sync: There are users in XWIki.XWikiAllGroup that don't exist, and users that exist that aren't in XWIki.XWikiAllGroup.
>>
>>  It seems to me that XWiki.XWikiAllGroup is special.  It should be treated in auth code as a magic word, like superadmin or XWiki.XWikiGuest, to mean "any user that exists in the DB for that wiki"  (XWikiGuest doesn't live in the DB.. ).
>>
>>  These "AllGroups" would still hold different members:   xwiki:XWiki.XWikiAllGroup, xwiki_virtual:XWiki.XWikiAllGroup
>>
>>  --
>>  This message is automatically generated by JIRA.
>>  -
>>  If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
>>  -
>>  For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>>    
>
>
>
>  


--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs